[PATCH] D124926: [LoopInterchange] New cost model for loop interchange

[Bardia Mahjour via Phabricator via llvm-commits]

bmahjour added a comment.

Some additional comments:

1. Could you please add a test directly under `llvm/test/Analysis/LoopCacheAnalysis` (not under PowerPC) to make sure the analysis produces different but sane costs when a) neither target triple nor option specified and b) option is specified but with a value different from the default.
2. I noticed some tests still have `target datalayout`. Do we need them? If not please remove.



================
Comment at: llvm/lib/Analysis/LoopCacheAnalysis.cpp:51-52
+    "default-cache-line-size", cl::init(64), cl::Hidden,
+    cl::desc("Use this to specify a cache line size if not provided by the "
+             "backend TargetTransformInfo"));
+
----------------



CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124926/new/

https://reviews.llvm.org/D124926