[PATCH] D126921: [RISCV] Untangle instruction properties from VSETVLIInfo [NFC]

[Philip Reames via Phabricator via llvm-commits]

reames added a comment.

@frasercrmck Let's not let perfection be the enemy of the good here.  I see the point you're raising, and I'm willing to explore it in a follow up patch, but can we get this one in first?  I see it as a significant improvement in the current code.

@kito-cheng No, I will not do as you propose.  These are properties of the instruction, trying to abstract them into an otherwise unrelated structure just makes the code confusing and hard to follow.  For clarity, I'm not objecting to maybe abstracting the policy bits (if we find other examples which share the same policies), I'm objecting to them being in the abstract state used in the forward dataflow.  These are *backwards* (e.g. demanded) facts.  If we had a bidirectional dataflow here, maybe merging them would make sense, but we don't.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126921/new/

https://reviews.llvm.org/D126921