[PATCH] D127254: [SelectionDAGISel] Chain any mayRaiseFPException instruction created from a strict FP node

[Eli Friedman via Phabricator via llvm-commits]

efriedma added a comment.

Would it make this code any simpler to say that nodes that can raise FP exceptions always have a chain, even if the original operation isn't strict?  I mean, that restricts scheduling a bit, but not sure we care.  Maybe it doesn't help, though...

How many PowerPC patterns need the CSE code?  Would it make sense to get rid of the CSE code, and just reimplement the relevant patterns using custom lowering, or something like that?

Besides that, I can't see any way to reduce the complexity here.  Maybe extract the "Update InputChain if there are any strict fp nodes" into a helper, since it looks like it's copy-pasted a few times.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127254/new/

https://reviews.llvm.org/D127254