[PATCH] D127209: [SVE][AArch64] Refine hasSVEArgsOrReturn

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 7 13:06:18 PDT 2022


efriedma added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64RegisterInfo.cpp:81
+           }
+           if (Ty->isFloatTy())
+             ZRegsUsed++;
----------------
Using isFloatTy() like this isn't going to be accurate.  If you want to correctly compute the registers used for a call, you really should just use the result of analyzeCallOperands() from isel.  Maybe compute it in isel, then save the result in AArch64FunctionInfo.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127209/new/

https://reviews.llvm.org/D127209



More information about the llvm-commits mailing list