[PATCH] D127131: Pipe potentially invalid InstructionCost through CodeMetrics

[Philip Reames via Phabricator via llvm-commits]

reames added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/DFAJumpThreading.cpp:834
+        LLVM_DEBUG(dbgs() << "DFA Jump Threading: Not jump threading, contains "
+                          << "instructions with illegal cost.\n");
+        ORE->emit([&]() {
----------------
craig.topper wrote:
> Are we using "illegal" or "invalid""? In LoopRotationUtils.cpp you used "invalid"
Invalid is the right term.  I'll fix the others.  Thanks.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127131/new/

https://reviews.llvm.org/D127131