[PATCH] D127131: Pipe potentially invalid InstructionCost through CodeMetrics

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 7 08:57:01 PDT 2022


craig.topper added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/DFAJumpThreading.cpp:834
+        LLVM_DEBUG(dbgs() << "DFA Jump Threading: Not jump threading, contains "
+                          << "instructions with illegal cost.\n");
+        ORE->emit([&]() {
----------------
Are we using "illegal" or "invalid""? In LoopRotationUtils.cpp you used "invalid"


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127131/new/

https://reviews.llvm.org/D127131



More information about the llvm-commits mailing list