[PATCH] D126910: [Alignment][NFC] Remove usage of MemSDNode::getAlignment

[Guillaume Chatelet via Phabricator via llvm-commits]

gchatelet marked 5 inline comments as done.
gchatelet added inline comments.


================
Comment at: llvm/lib/Target/ARM/ARMISelLowering.cpp:5583
+                          Ld->getPointerInfo().getWithOffset(4),
+                          std::min(Ld->getAlign(), Align(4)),
                           Ld->getMemOperand()->getFlags());
----------------
courbet wrote:
> Even though this works, I think this is conceptually misleading: `4` here is an offset, not an alignment. So I think this should be:
> 
> `commonAlignment(Ld->getAlign(), 4)`
> 
> 
Good catch, thx!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126910/new/

https://reviews.llvm.org/D126910