[PATCH] D127147: [DirectX] Add MC Register and Frame stubs

[Jakub Kuderski via Phabricator via llvm-commits]

kuhar added inline comments.


================
Comment at: llvm/lib/Target/DirectX/DirectXFrameLowering.h:29-34
+  void emitPrologue(MachineFunction &MF,
+                    MachineBasicBlock &MBB) const override {}
+  void emitEpilogue(MachineFunction &MF,
+                    MachineBasicBlock &MBB) const override {}
+
+  bool hasFP(const MachineFunction &MF) const override { return false; }
----------------
I'm afraid these can lead to unused function argument warnings. Can we remove argument names to silence such warnings?


================
Comment at: llvm/lib/Target/DirectX/DirectXInstrInfo.h:26
+
+  ~DirectXInstrInfo() override = default;
+};
----------------
AFAIK at least one virtual function should be defined in a C++ file: https://llvm.org/docs/CodingStandards.html#provide-a-virtual-method-anchor-for-classes-in-headers


================
Comment at: llvm/lib/Target/DirectX/DirectXRegisterInfo.h:24
+  DirectXRegisterInfo() : DirectXGenRegisterInfo(0) {}
+  ~DirectXRegisterInfo() override = default;
+};
----------------
Also here


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127147/new/

https://reviews.llvm.org/D127147