[PATCH] D127147: [DirectX] Add MC Register and Frame stubs
Chris Bieneman via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jun 6 14:25:35 PDT 2022
beanz added a comment.
In D127147#3561579 <https://reviews.llvm.org/D127147#3561579>, @python3kgae wrote:
> Do we need any test for this change?
This is complicated... This particular patch is effectively NFC. Since there is no implementation to any of this code, it doesn't actually _do_anything (and really never will).
There are other patches in this stack (some not yet posted) which do have functionality, but they also aren't very testable because the MC-layer (and particularly the object streamer infrastructure) isn't architected to be as flexible for testing as other parts of LLVM.
Before any of this code becomes live a lot of other code all needs to fall into place. I'm working on getting the full patch set posted.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D127147/new/
https://reviews.llvm.org/D127147
More information about the llvm-commits
mailing list