[PATCH] D126936: [compiler-rt] Handle target and sysroot flags in tests

[Dan Liew via Phabricator via llvm-commits]

delcypher added inline comments.


================
Comment at: compiler-rt/test/lit.common.cfg.py:699
+if config.target_triple:
+  extra_cflags += ["--target=%s" % config.target_triple]
+if config.sysroot:
----------------
I haven't verified this but I think this very likely to break testing for Apple platforms. I don't think `config.target_triple` is set correctly. IIRC we rely on the target triple being inferred from the SDK and arch being used. This isn't a good situation to be in, explicit would definitely be better.


================
Comment at: compiler-rt/test/lit.common.cfg.py:701
+if config.sysroot:
+  extra_cflags += ["--sysroot=%s" % config.sysroot]
+if config.osx_sysroot:
----------------
We should check but I doubt this is configured correctly. It's probably correct for macOS but broken for other Apple platforms because I suspect `config.sysroot` might always be set to a macOS SDK path.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126936/new/

https://reviews.llvm.org/D126936