[PATCH] D126936: [compiler-rt] Handle target and sysroot flags in tests

Mon Jun 6 14:14:00 PDT 2022

phosek added a comment.

In D126936#3556967 <https://reviews.llvm.org/D126936#3556967>, @yln wrote:

> Looks sensible to me, but I don't understand the implications here.
>
> Can you explain why this is needed/what doesn't work right now?
> @phosek

In our case we build against an explicit sysroot or SDK, even when the host matches the target. This is to ensure that we don't accidentally introduce dependency on libraries (or their versions) that are only present on certain hosts. We noticed recently that test binaries don't follow the CMake configuration when we saw test failures that only affected some hosts. The goal of this change is to make the behavior CMake and lit more consistent.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126936/new/

https://reviews.llvm.org/D126936