[PATCH] D123963: AMDGPU: Make PSV instances static members

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/SIMachineFunctionInfo.cpp:34
   : AMDGPUMachineFunction(MF),
+    BufferPSV(static_cast<const AMDGPUTargetMachine &>(MF.getTarget())),
+    ImagePSV(static_cast<const AMDGPUTargetMachine &>(MF.getTarget())),
----------------
foad wrote:
> It doesn't look like these constructors really need an AMDGPUTargetMachine. Couldn't they all take an LLVMTargetMachine instead?
I usually just keep it as the target machine in target code since it's always known


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123963/new/

https://reviews.llvm.org/D123963