[PATCH] D123963: AMDGPU: Make PSV instances static members
Jay Foad via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jun 6 09:04:27 PDT 2022
foad added inline comments.
================
Comment at: llvm/lib/Target/AMDGPU/SIMachineFunctionInfo.cpp:34
: AMDGPUMachineFunction(MF),
+ BufferPSV(static_cast<const AMDGPUTargetMachine &>(MF.getTarget())),
+ ImagePSV(static_cast<const AMDGPUTargetMachine &>(MF.getTarget())),
----------------
It doesn't look like these constructors really need an AMDGPUTargetMachine. Couldn't they all take an LLVMTargetMachine instead?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D123963/new/
https://reviews.llvm.org/D123963
More information about the llvm-commits
mailing list