[PATCH] D126546: [InstCombine] decomposeSimpleLinearExpr should bail out on negative operands.
wael yehia via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jun 6 11:39:13 PDT 2022
w2yehia added inline comments.
================
Comment at: llvm/test/Transforms/InstCombine/neg-alloca.ll:1
+; RUN: opt -S -passes=instcombine < %s | FileCheck %s
+ at test = external global [1 x i32], align 16
----------------
nikic wrote:
> Please use the llvm/utils/update_test_checks.py script to generate CHECK lines.
>
> Also, I think that this test case may be reduced, I don't think you really need much more than then mul+add+alloca+bitcast sequence?
I reduced the testcase, and made the RUN command canonical (based on suggestions in update_test_checks.py).
I think the current CHECKs capture the required functionality best.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D126546/new/
https://reviews.llvm.org/D126546
More information about the llvm-commits
mailing list