[PATCH] D126546: [InstCombine] decomposeSimpleLinearExpr should bail out on negative operands.

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 6 07:21:27 PDT 2022


nikic added inline comments.


================
Comment at: llvm/test/Transforms/InstCombine/neg-alloca.ll:1
+; RUN: opt -S -passes=instcombine < %s | FileCheck %s
+ at test = external global [1 x i32], align 16
----------------
Please use the llvm/utils/update_test_checks.py script to generate CHECK lines.

Also, I think that this test case may be reduced, I don't think you really need much more than then mul+add+alloca+bitcast sequence?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126546/new/

https://reviews.llvm.org/D126546



More information about the llvm-commits mailing list