[PATCH] D126700: [MachineScheduler] Order more stores by ascending address

Dave Green via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 6 02:36:36 PDT 2022


dmgreen added a comment.

Do you have more details on where and when you expect this to be beneficial? It may not look like it from the review, but we did a fair amount of testing and benchmarking was done on D125377 <https://reviews.llvm.org/D125377> on all kinds of CPUs (in-order vs out-of-order, little vs big, etc) to make sure that it was an improvement or benign on the cases we tried. I don't think I would be against this - so long as we had a decent reason to do so. It does constrain the scheduling graph though, so we shouldn't do so unnecessarily.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126700/new/

https://reviews.llvm.org/D126700



More information about the llvm-commits mailing list