[PATCH] D126950: [lld][WebAssembly] Retain data segments referenced via __start/__stop
Yuta Saito via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Jun 3 11:01:17 PDT 2022
kateinoigakukun added inline comments.
================
Comment at: lld/test/wasm/gc-sections-metadata-startstop.s:1
+# RUN: llvm-mc -triple=wasm32-unknown-unknown -filetype=obj -o %t.o %s
+# RUN: wasm-ld %t.o -o %t.wasm
----------------
sbc100 wrote:
> Why not just call this `gc-sections-startstop.s`.. what is the `metadata` part referring too?
startstop feature is often used as metadata mechanism, so some other test cases have the `metadata` part as well, but it's fine to remove that part since it's descriptive enough.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D126950/new/
https://reviews.llvm.org/D126950
More information about the llvm-commits
mailing list