[PATCH] D126950: [lld][WebAssembly] Retain data segments referenced via __start/__stop

[Sam Clegg via Phabricator via llvm-commits]

sbc100 added inline comments.


================
Comment at: lld/test/wasm/gc-sections-metadata-startstop.s:1
+# RUN: llvm-mc -triple=wasm32-unknown-unknown -filetype=obj -o %t.o %s
+# RUN: wasm-ld %t.o -o %t.wasm
----------------
Why not just call this `gc-sections-startstop.s`..   what is the `metadata` part referring too?


================
Comment at: lld/wasm/MarkLive.cpp:117
+    for (InputChunk *segment : obj->segments) {
+      auto name = segment->getOutputSegmentName();
+      if (!isValidCIdentifier(name))
----------------
I think you can just use `segment->name`  here.  That is what ELF seems to do


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126950/new/

https://reviews.llvm.org/D126950