[PATCH] D126968: [CodeView] Fix incorrect CodeView encoding of signed integer constants

Fri Jun 3 10:56:40 PDT 2022

smerritt added inline comments.

================
Comment at: llvm/lib/DebugInfo/CodeView/CodeViewRecordIO.cpp:281-283
   // FIXME: There are no test cases covering this function.
   // This may be because we always consider enumerators to be unsigned.
   // See FIXME at CodeViewDebug.cpp : CodeViewDebug::lowerTypeEnum.
----------------
rnk wrote:
> Is this FIXME addressed? If so, we should remove it.
Unfortunately no, the new test I added exercises the writeEncodedSignedInteger routine but I did not find a case to exercise this routine.  I updated the code here to keep the routines in sync.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126968/new/

https://reviews.llvm.org/D126968