[PATCH] D126968: [CodeView] Fix incorrect CodeView encoding of signed integer constants
Reid Kleckner via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Jun 3 10:37:17 PDT 2022
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm, thanks
================
Comment at: llvm/lib/DebugInfo/CodeView/CodeViewRecordIO.cpp:281-283
// FIXME: There are no test cases covering this function.
// This may be because we always consider enumerators to be unsigned.
// See FIXME at CodeViewDebug.cpp : CodeViewDebug::lowerTypeEnum.
----------------
Is this FIXME addressed? If so, we should remove it.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D126968/new/
https://reviews.llvm.org/D126968
More information about the llvm-commits
mailing list