[PATCH] D126976: [lld][WebAssembly][NFC] Move getOutputSegmentName to InputChunk methods

[Yuta Saito via Phabricator via llvm-commits]

kateinoigakukun abandoned this revision.
kateinoigakukun added inline comments.


================
Comment at: lld/wasm/InputChunks.cpp:531
+    return ".tdata";
+  StringRef name = getName();
+  if (!config->mergeDataSegments)
----------------
sbc100 wrote:
> Actually, looking at this code and looking at how ELF does this.. I think you can just use `getName` in the other patch and maybe this patch is not actually needed?
> 
> None of these combined segments return true for `isValidCIdentifier` so I think you can just to what ELF in its MakeLive.cpp and use the intput section name.
Ah, it makes sense to me.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126976/new/

https://reviews.llvm.org/D126976