[PATCH] D126977: [config] Remove vestigial LLVM_VERSION_INFO

[Reid Kleckner via Phabricator via llvm-commits]

rnk created this revision.
rnk added a reviewer: tstellar.
Herald added subscribers: ormris, steven_wu, hiraditya, mgorny.
Herald added a project: All.
rnk requested review of this revision.
Herald added a project: LLVM.

This has been superseded by the llvm/Support/VCSRevision.h header. So
far as I can tell, nothing in the CMake build sets LLVM_VERSION_INFO. It
was always undefined, and the ifdefs using it were dead. However, CMake
is very flexible, so it's possible that I missed some ways to set this
variable. One could, for example, probably pass -DLLVM_VERSION_INFO=x on
the command line and get that through to configure_file, or set the
variable in an obscure way (`set(${proj}_VERSION_INFO "x")`). I'm
reasonably confident that isn't happening, but I'd like a second
opinion.

Update the Bazel and gn builds accordingly.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D126977

Files:
  llvm/include/llvm/Config/config.h.cmake
  llvm/lib/LTO/LTOCodeGenerator.cpp
  llvm/lib/Support/CommandLine.cpp
  llvm/utils/gn/secondary/llvm/include/llvm/Config/BUILD.gn
  utils/bazel/llvm-project-overlay/llvm/BUILD.bazel
  utils/bazel/llvm-project-overlay/llvm/include/llvm/Config/config.h
  utils/bazel/llvm_configs/config.h.cmake

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D126977.434062.patch
Type: text/x-patch
Size: 4208 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220603/c11e8d71/attachment.bin>