[PATCH] D126952: [DAGCombiner] Remove overzealous assertion when folding assert+trunc+assert (PR55846)

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 3 05:48:38 PDT 2022


spatel accepted this revision.
spatel added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: llvm/test/CodeGen/X86/pr55846.ll:4
+
+define void @test(i64* %p) {
+; CHECK-LABEL: test:
----------------
Put a comment on this test, so we don't have to dig for its purpose?
  ; After legalization, this could be: "i8 truncate (i64 AssertZext X, Type: i9)"
  ; The AssertZext does not add information, so it should be eliminated,
  ; but that must not trigger a compile-time assert.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126952/new/

https://reviews.llvm.org/D126952



More information about the llvm-commits mailing list