[PATCH] D124926: [LoopInterchange] New cost model for loop interchange

Fri Jun 3 01:17:04 PDT 2022

fhahn added a comment.

In D124926#3555072 <https://reviews.llvm.org/D124926#3555072>, @congzhe wrote:

> In D124926#3555002 <https://reviews.llvm.org/D124926#3555002>, @kaz7 wrote:
>
>> Hi, after this patch, our buildbot for VE has been failing, https://lab.llvm.org/buildbot/#/builders/91/builds/9844.  Is it possible to inspect these failures?  Thanks.
>
> Thanks for letting me know. On my local machine I am not seeing test failures. Would you please let me know which test and what command failed so I can look into it? The link above does not seem to contain information.

The issue is likely that all tests now depend on the PowerPC target to be built.  This won't work as expected when LLVM is built with the PPC backend disabled. This is causing the test failures.

The tests as they are written at the moment would need something like `; REQUIRES: powerpc-registered-target` to only run them when the target is available. If a lot of tests require a specific target to run, usually they are place in `PowerPC` sub-directory, which has a lit file limiting them to run only when the target is available.

Having all tests depend on a single target is not ideal, because this limits the number of bots/configurations that run the tests. I think we need a way to keep most of the tests independent of the PowerPC or any other target and only have tests that explicitly test the cost-modeling depend on the target.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124926/new/

https://reviews.llvm.org/D124926