[PATCH] D126425: [llvm-ml] Add support for the .S extension

Alan Zhao via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 2 17:07:04 PDT 2022


ayzhao added a comment.

In D126425#3547306 <https://reviews.llvm.org/D126425#3547306>, @epastor wrote:

> In D126425#3545711 <https://reviews.llvm.org/D126425#3545711>, @hans wrote:
>
>> It appears to me that MASM doesn't care much about the file extension at all:
>
> [test results omitted]
>
>> The fact that `/Ta` exists suggest maybe it did care at some point, but that may have changed.
>
> Thanks for doing the testing! Sounds like something we should match them on, then... `/Ta` will still be useful when on systems where a filename could start with a `/`, so we shouldn't make it a no-op, but otherwise let's remove the extension restriction.
>
> (Assuming this still holds for ml.exe, as well as ml64.exe... they do have different behavior sometimes.)

D126931 <https://reviews.llvm.org/D126931> removes all file extension restrictions.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126425/new/

https://reviews.llvm.org/D126425



More information about the llvm-commits mailing list