[PATCH] D126425: [llvm-ml] Add support for the .S extension

Eric Astor via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 31 07:08:24 PDT 2022


epastor added a comment.

In D126425#3545711 <https://reviews.llvm.org/D126425#3545711>, @hans wrote:

> It appears to me that MASM doesn't care much about the file extension at all:

[test results omitted]

> The fact that `/Ta` exists suggest maybe it did care at some point, but that may have changed.

Thanks for doing the testing! Sounds like something we should match them on, then... `/Ta` will still be useful when on systems where a filename could start with a `/`, so we shouldn't make it a no-op, but otherwise let's remove the extension restriction.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126425/new/

https://reviews.llvm.org/D126425



More information about the llvm-commits mailing list