[PATCH] D126883: [Debuginfo][DWARF][NFC] Refactor DwarfStringPoolEntry.

[Alexey Lapshin via Phabricator via llvm-commits]

avl added a comment.

In D126883#3554448 <https://reviews.llvm.org/D126883#3554448>, @dblaikie wrote:

> Might be worth splitting up further - removing the indexed support in a separate patch?

Ok.

>> Add possibility to keep not only DwarfStringPoolEntry, but also pointer to it.
>
> Looks like this functionality is added, but untested - it'd be good to include some test coverage for it, somehow? Maybe worth adding a unit test?

I thought it(test) will come with D96035 <https://reviews.llvm.org/D96035>. Will add it for this review as requested.

> (general feedback: avoid else-after-return, please check over the change for a few insntances of that)




Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126883/new/

https://reviews.llvm.org/D126883