[PATCH] D126883: [Debuginfo][DWARF][NFC] Refactor DwarfStringPoolEntry.
David Blaikie via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jun 2 13:28:58 PDT 2022
dblaikie added a comment.
Might be worth splitting up further - removing the indexed support in a separate patch?
> Add possibility to keep not only DwarfStringPoolEntry, but also pointer to it.
Looks like this functionality is added, but untested - it'd be good to include some test coverage for it, somehow? Maybe worth adding a unit test?
(general feedback: avoid else-after-return, please check over the change for a few insntances of that)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D126883/new/
https://reviews.llvm.org/D126883
More information about the llvm-commits
mailing list