[PATCH] D126894: [SLP][NFC] Precommit for a followup patch that fixes vectorization of phi when they come from unreachable blocks

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 2 10:15:22 PDT 2022


MaskRay accepted this revision.
MaskRay added a comment.
This revision is now accepted and ready to land.
Herald added a subscriber: StephenFan.

LGTM.



================
Comment at: llvm/test/Transforms/SLPVectorizer/X86/phi-unreachable-input-block.ll:36
+  %zext1 = zext i8 %phi1 to i64
+  %gep0 = getelementptr i64, i64* %ptr, i64 0
+  %gep1 = getelementptr i64, i64* %ptr, i64 1
----------------
consider switching to `ptr` for opaque pointers (https://llvm.org/docs/OpaquePointers.html)

Opaque pointers have been the default. Non-opaque pointers are considered legacy now.


================
Comment at: llvm/test/Transforms/SLPVectorizer/X86/phi-unreachable-input-block.ll:112
+}
+
----------------
delete blank line


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126894/new/

https://reviews.llvm.org/D126894



More information about the llvm-commits mailing list