[llvm] 01ba470 - [RISCV] Add test case showing unnecessary extend after i32 smax on rv64. NFC

[Craig Topper via llvm-commits]

Author: Craig Topper
Date: 2022-06-02T09:58:11-07:00
New Revision: 01ba470826a84a8d73e88916605b838bb962f52a

URL: https://github.com/llvm/llvm-project/commit/01ba470826a84a8d73e88916605b838bb962f52a
DIFF: https://github.com/llvm/llvm-project/commit/01ba470826a84a8d73e88916605b838bb962f52a.diff

LOG: [RISCV] Add test case showing unnecessary extend after i32 smax on rv64. NFC

One of the operands of the smax is a positive value so computeKnownBits
determines the result of the smax must always be positive. This allows
DAG combiner to convert the sign extend to zero extend before type
legalization.

After type legalization the smax is promoted to i64 by sign extending
its inputs and the zero extend becomes an AND instruction. We are unable
to remove the AND at this point and it becomes a pair of shifts or a
zext.w.

The result of smax has as many sign bits as the minimum of its inputs.
Had we kept the sign extend instead of turning it into a zero extend
it would be removed by DAG combiner after type legalization.

Added: 
    

Modified: 
    llvm/test/CodeGen/RISCV/min-max.ll

Removed: 
    


################################################################################
diff  --git a/llvm/test/CodeGen/RISCV/min-max.ll b/llvm/test/CodeGen/RISCV/min-max.ll
index bd3160622ab7..158dbcc6f5a9 100644
--- a/llvm/test/CodeGen/RISCV/min-max.ll
+++ b/llvm/test/CodeGen/RISCV/min-max.ll
@@ -620,3 +620,40 @@ define signext i32 @umax_undef_i32() {
   ret i32 %c
 }
 
+define signext i32 @smax_i32_pos_constant(i32 signext %a) {
+; RV32I-LABEL: smax_i32_pos_constant:
+; RV32I:       # %bb.0:
+; RV32I-NEXT:    li a1, 10
+; RV32I-NEXT:    blt a1, a0, .LBB24_2
+; RV32I-NEXT:  # %bb.1:
+; RV32I-NEXT:    li a0, 10
+; RV32I-NEXT:  .LBB24_2:
+; RV32I-NEXT:    ret
+;
+; RV64I-LABEL: smax_i32_pos_constant:
+; RV64I:       # %bb.0:
+; RV64I-NEXT:    li a1, 10
+; RV64I-NEXT:    blt a1, a0, .LBB24_2
+; RV64I-NEXT:  # %bb.1:
+; RV64I-NEXT:    li a0, 10
+; RV64I-NEXT:  .LBB24_2:
+; RV64I-NEXT:    slli a0, a0, 32
+; RV64I-NEXT:    srli a0, a0, 32
+; RV64I-NEXT:    ret
+;
+; RV32ZBB-LABEL: smax_i32_pos_constant:
+; RV32ZBB:       # %bb.0:
+; RV32ZBB-NEXT:    li a1, 10
+; RV32ZBB-NEXT:    max a0, a0, a1
+; RV32ZBB-NEXT:    ret
+;
+; RV64ZBB-LABEL: smax_i32_pos_constant:
+; RV64ZBB:       # %bb.0:
+; RV64ZBB-NEXT:    li a1, 10
+; RV64ZBB-NEXT:    max a0, a0, a1
+; RV64ZBB-NEXT:    slli a0, a0, 32
+; RV64ZBB-NEXT:    srli a0, a0, 32
+; RV64ZBB-NEXT:    ret
+  %c = call i32 @llvm.smax.i32(i32 %a, i32 10)
+  ret i32 %c
+}