[PATCH] D126355: [FuncSpec]Fix assertion failure when lattice value is not found.

Wed Jun 1 22:24:08 PDT 2022

sinan added a comment.

In D126355#3536597 <https://reviews.llvm.org/D126355#3536597>, @ChuanqiXu wrote:

> We should generate a patch with option `-U9999` to offer more context to review.
>
> Thanks for working on this. Have you measured any performance/code size change?
>
> Also, I feel we could do better since we've already mark it as overrefined in https://github.com/llvm/llvm-project/blob/cd2292ef824591cc34cc299910a3098545c840c7/llvm/lib/Transforms/Utils/SCCPSolver.cpp#L1254 
> So it looks possible to get the lattice successfully.

Hi,

I tested with flag -Wl,-mllvm,--enable-function-specialization on Spec 2017. No noticeable regression in compilation time(measured by -fproc-stat-report) and performance were found.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126355/new/

https://reviews.llvm.org/D126355