[PATCH] D126834: [memprof] Display segment information, update summary output.

[Snehasish Kumar via Phabricator via llvm-commits]

snehasish added a comment.

PTAL, thanks!



================
Comment at: llvm/lib/ProfileData/RawMemProfReader.cpp:229
+  OS << "    NumSegments: " << SegmentInfo.size() << "\n";
+  OS << "    NumAllocFunctions: " << NumAllocFunctions << "\n";
+  OS << "    NumStackOffsets: " << StackMap.size() << "\n";
----------------
tejohnson wrote:
> It looks like before we printed out the number of MIBs and now we print out the number of functions containing at least one alloc - is that intended? Should we print out both?
Done, extended the logic to print out both.


================
Comment at: llvm/test/tools/llvm-profdata/memprof-multi.test:38
 
 We expect 2 MIB entries, 1 each for the malloc calls in the program.
 
----------------
tejohnson wrote:
> Comment seems stale unless the summary is changed to print number of MIBs again.
Actually, in this case I added additional check lines below to ensure 2 MIBs are printed (symbolname, lineoffset and column). I extended the logic to also track the number of MIBs so that it's clearer.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126834/new/

https://reviews.llvm.org/D126834