[PATCH] D123919: [mlir][OpenMP] omp.task translation to LLVM IR

[Michael Kruse via Phabricator via llvm-commits]

Meinersbur added a comment.

In D123919#3542895 <https://reviews.llvm.org/D123919#3542895>, @shraiysh wrote:

> In D123919#3542687 <https://reviews.llvm.org/D123919#3542687>, @Meinersbur wrote:
>
>> A bit-ness question
>
> I didn’t understand this comment. Is this a typo or incomplete comment?

Sorry, I added an inline-comment but Phabricator refused to submit without also adding something in the main comment box. Now, I don't see the inline-comment so that may the reason Phabricator complained.



================
Comment at: mlir/test/Target/LLVMIR/openmp-llvm.mlir:2146
+  // CHECK: %[[task_data:.+]] = call i8* @__kmpc_omp_task_alloc
+  // CHECK-SAME: (%{{.+}}, i32 %[[omp_global_thread_num]], i32 1, i64 16, i64 0,
+  // CHECK-SAME: i32 (i32, i8*)* bitcast (i32 (i32, { i32, i32, i32* }*)*
----------------
shraiysh wrote:
> kiranchandramohan wrote:
> > Why is the task size 16 and not 12 (for the three liveins)?
> `x` and `y` are 4-byte each, and the pointer `zaddr` is of 8 bytes (64-bit). So, the total is 16.
A pointer is 8 bytes only on 64-bit platforms. Does this mean that this test will fail on platforms that have pointers of different sizes? I also don't see the target triple fixed by mlir-translate, so will this test fail on non-64 hosts?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123919/new/

https://reviews.llvm.org/D123919