[PATCH] D123919: [mlir][OpenMP] omp.task translation to LLVM IR

[Peixin Qiao via Phabricator via llvm-commits]

peixin accepted this revision.
peixin added a comment.

LGTM



================
Comment at: llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp:1329
     // Arguments - `loc_ref` (Ident) and `gtid` (ThreadID)
     // call.
     Value *Ident = getOrCreateIdent(SrcLocStr, SrcLocStrSize);
----------------
Nit: move "call." to line 1328.


================
Comment at: mlir/lib/Target/LLVMIR/Dialect/OpenMP/OpenMPToLLVMIRTranslation.cpp:689
+      !taskOp.allocate_vars().empty()) {
+    return taskOp.emitError("unhandled clauses for translation to LLVM IR");
+  }
----------------
Nit


================
Comment at: mlir/lib/Target/LLVMIR/Dialect/OpenMP/OpenMPToLLVMIRTranslation.cpp:691
+  }
+  auto bodyCB = [&](InsertPointTy allocaIP, InsertPointTy codegenIP) {
+    builder.restoreIP(codegenIP);
----------------
Is allocaIP used in this?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123919/new/

https://reviews.llvm.org/D123919