[PATCH] D126575: [ccache] Add Windows support

[Nathaniel McVicar via Phabricator via llvm-commits]

NathanielMcVicar updated this revision to Diff 433231.
NathanielMcVicar added a comment.

Add comment for RULE_LAUNCH_COMPILE on Windows


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126575/new/

https://reviews.llvm.org/D126575

Files:
  llvm/CMakeLists.txt


Index: llvm/CMakeLists.txt
===================================================================
--- llvm/CMakeLists.txt
+++ llvm/CMakeLists.txt
@@ -192,6 +192,8 @@
          NOT LLVM_CCACHE_PARAMS MATCHES "CCACHE_CPP2=yes CCACHE_HASHDIR=yes")
         message(FATAL_ERROR "Ccache configuration through CMake is not supported on Windows. Please use environment variables.")
       endif()
+      # RULE_LAUNCH_COMPILE should work with Ninja but currently has issues
+      # with cmd.exe and some MSVC tools other than cl.exe
       set(CMAKE_C_COMPILER_LAUNCHER ${CCACHE_PROGRAM})
       set(CMAKE_CXX_COMPILER_LAUNCHER ${CCACHE_PROGRAM})     
     endif()


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D126575.433231.patch
Type: text/x-patch
Size: 656 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220531/f82966e9/attachment.bin>