[PATCH] D126575: [ccache] Add Windows support

[Stella Stamenova via Phabricator via llvm-commits]

stella.stamenova accepted this revision.
stella.stamenova added a comment.

LGTM



================
Comment at: llvm/CMakeLists.txt:195
+      endif()
+      set(CMAKE_C_COMPILER_LAUNCHER ${CCACHE_PROGRAM})
+      set(CMAKE_CXX_COMPILER_LAUNCHER ${CCACHE_PROGRAM})     
----------------
Can you add a comment that we can't use RULE_LAUNCH_COMPILE on Windows even though in theory it should be able to work?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126575/new/

https://reviews.llvm.org/D126575