[PATCH] D126635: [RISCV] Fix a few corner case bugs in RISCVMergeBaseOffsetOpt::matchLargeOffset

Luís Marques via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 31 02:47:04 PDT 2022


luismarques accepted this revision.
luismarques added a comment.
This revision is now accepted and ready to land.

LGTM.



================
Comment at: llvm/test/CodeGen/RISCV/hoist-global-addr-base.ll:217-229
+; RV32-NEXT:    lui a0, %hi(bar-8191)
+; RV32-NEXT:    addi a0, a0, %lo(bar-8191)
 ; RV32-NEXT:    ret
 ;
 ; RV64-LABEL: neg_offset:
 ; RV64:       # %bb.0:
 ; RV64-NEXT:    lui a0, %hi(bar)
----------------
I'm surprised this issue wasn't noticed before.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126635/new/

https://reviews.llvm.org/D126635



More information about the llvm-commits mailing list