[PATCH] D126618: [VPlan] Replace CondBit with BranchOnCond VPInstruction.

[Florian Hahn via Phabricator via llvm-commits]

fhahn updated this revision to Diff 432986.
fhahn marked an inline comment as done.
fhahn added a comment.

Address latest comments, thanks!

In D126618#3544964 <https://reviews.llvm.org/D126618#3544964>, @Ayal wrote:

> Should tests check for new BranchOnCond VPInstruction?

There's `Transforms/LoopVectorize/vplan-printing-outer-loop.ll` now, which tests  this.

> Are the users of CondBit/Predicate ok w/ this change (VPlanPredicator)?

There are no remaining users after this change. VPlanPredicator at the current stage is not used and would need major updates to support the new region structure. There's D123017 <https://reviews.llvm.org/D123017> to remove it, which has been approved and I plan to land this soon, ideally once D123005 <https://reviews.llvm.org/D123005> is ready/


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126618/new/

https://reviews.llvm.org/D126618

Files:
  llvm/lib/Transforms/Vectorize/LoopVectorize.cpp
  llvm/lib/Transforms/Vectorize/VPlan.cpp
  llvm/lib/Transforms/Vectorize/VPlan.h
  llvm/lib/Transforms/Vectorize/VPlanHCFGBuilder.cpp
  llvm/lib/Transforms/Vectorize/VPlanTransforms.cpp
  llvm/lib/Transforms/Vectorize/VPlanValue.h
  llvm/lib/Transforms/Vectorize/VPlanVerifier.cpp
  llvm/test/Transforms/LoopVectorize/first-order-recurrence-sink-replicate-region.ll
  llvm/test/Transforms/LoopVectorize/icmp-uniforms.ll
  llvm/test/Transforms/LoopVectorize/vplan-printing-outer-loop.ll
  llvm/test/Transforms/LoopVectorize/vplan-printing.ll
  llvm/test/Transforms/LoopVectorize/vplan-sink-scalars-and-merge-vf1.ll
  llvm/test/Transforms/LoopVectorize/vplan-sink-scalars-and-merge.ll
  llvm/unittests/Transforms/Vectorize/VPlanHCFGTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D126618.432986.patch
Type: text/x-patch
Size: 30920 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220530/7bce8802/attachment.bin>