[PATCH] D126487: [SVE] Fixed custom lowering of ISD::INSERT_SUBVECTOR.

[Paul Walker via Phabricator via llvm-commits]

paulwalker-arm added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:11480
 
-    EVT WideVT;
-    SDValue ExtVec;
+    EVT NarrowVT = getPackedSVEVectorVT(VT.getVectorElementCount());
+    EVT WideVT = getPackedSVEVectorVT(InVT.getVectorElementCount());
----------------
david-arm wrote:
> Are these names the wrong way around? I would have expected the wider `VT` to be called `WideVT`. We're inserting a narrower InVT subvector into a wider VT vector.
It's wider in the context of the element type since both types have the same total bit length. `WideVT` is the wider VT because it's created based on the element count.  `InVT` (i.e. the subvector) has fewer elements than `VT` and thus its element type will need to be wider in order to match the total bit length of `NarrowVT`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126487/new/

https://reviews.llvm.org/D126487