[PATCH] D126487: [SVE] Fixed custom lowering of ISD::INSERT_SUBVECTOR.

Mon May 30 04:35:41 PDT 2022

peterwaller-arm accepted this revision.
peterwaller-arm added a comment.
This revision is now accepted and ready to land.

LGTM.

An observation: `nounwind` only appears to affect output for 5 tests, in case there is an appetite to remove it elsewhere: insert_v2i64_nxv2i64_idx2 / insert_v4i32_nxv4i32_idx4 / insert_v16i8_nxv16i8_idx16 / insert_nxv8f16_nxv2f16 / insert_nxv4bf16_v4bf16.

================
Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:11493
+    // To replace the top/bottom half of vector V with vector SubV we widen the
+    // preserved half of V, concatinate this to SubV (the order dependant on the
+    // half being replaced) and then narrow the result.
----------------
nit: s/concatinate/concatenate/ s/dependant/dependent/ or perhaps s/dependant/depending/.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126487/new/

https://reviews.llvm.org/D126487