[PATCH] D125627: [SCEV] Serialize function calls in function arguments.

[Nikita Popov via Phabricator via llvm-commits]

nikic added inline comments.


================
Comment at: llvm/lib/Analysis/ScalarEvolution.cpp:1807
+      const auto *LHSz = getZeroExtendExpr(LHS, Ty, Depth + 1);
+      const auto *RHSz = getZeroExtendExpr(RHS, Ty, Depth + 1);
+      return getURemExpr(LHSz, RHSz);
----------------
chapuni wrote:
> nikic wrote:
> > I'd just reassign LHS and RHS here (and below). The LHSz/RHSz names are bit unusual.
> I was afraid since LHS and RHS are captured and assigned by matchURem(const SCEV*, const SCEV*&, const SCEV*&)
> I thought they might be dedicated to matchURem().
> 
> How about;
> - Rename original LHS,RHS to LHSURem,RHSURem
> - Use LHS,RHS as generic instead of my LHSz,RHSz
I don't think the capture here matters. These are just out parameters for matchURem, it's fine to reuse the variables.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125627/new/

https://reviews.llvm.org/D125627