[PATCH] D126388: [AMDGPU][GFX9] Support base+soffset+offset SMEM stores.

[Ivan Kosarev via Phabricator via llvm-commits]

kosarev added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/SMInstructions.td:604
+class SMEM_Real_Store_vi <bits<8> op, string ps, dag offsets>
+    : SMEM_Real_Store_Probe_vi <op, !cast<SM_Pseudo>(ps)> {
+  RegisterClass SrcClass = !cast<SM_Store_Pseudo>(ps).SrcClass;
----------------
dp wrote:
> This is a matter of taste, but I'd have renamed SMEM_Real_Store_Probe_vi to SMEM_Real_Store_Base_vi.
Sounds a good idea. Went to rGb4dbcba3b7b7.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126388/new/

https://reviews.llvm.org/D126388