[PATCH] D126628: [JITLink][AARCH64][NFC] Create isLoadStoreImm12 function by splitting getPageOffset12Shift

[Sunho Kim via Phabricator via llvm-commits]

sunho updated this revision to Diff 432864.
Herald added a subscriber: hiraditya.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126628/new/

https://reviews.llvm.org/D126628

Files:
  llvm/include/llvm/ExecutionEngine/JITLink/aarch64.h
  llvm/lib/ExecutionEngine/JITLink/aarch64.cpp


Index: llvm/lib/ExecutionEngine/JITLink/aarch64.cpp
===================================================================
--- llvm/lib/ExecutionEngine/JITLink/aarch64.cpp
+++ llvm/lib/ExecutionEngine/JITLink/aarch64.cpp
@@ -18,11 +18,15 @@
 namespace jitlink {
 namespace aarch64 {
 
-unsigned getPageOffset12Shift(uint32_t Instr) {
+bool isLoadStoreImm12(uint32_t Instr) {
   constexpr uint32_t LoadStoreImm12Mask = 0x3b000000;
+  return (Instr & LoadStoreImm12Mask) == 0x39000000;
+}
+
+unsigned getPageOffset12Shift(uint32_t Instr) {
   constexpr uint32_t Vec128Mask = 0x04800000;
 
-  if ((Instr & LoadStoreImm12Mask) == 0x39000000) {
+  if (isLoadStoreImm12(Instr)) {
     uint32_t ImplicitShift = Instr >> 30;
     if (ImplicitShift == 0)
       if ((Instr & Vec128Mask) == Vec128Mask)
@@ -30,8 +34,6 @@
 
     return ImplicitShift;
   }
-
-  return 0;
 }
 
 Error applyFixup(LinkGraph &G, Block &B, const Edge &E) {
Index: llvm/include/llvm/ExecutionEngine/JITLink/aarch64.h
===================================================================
--- llvm/include/llvm/ExecutionEngine/JITLink/aarch64.h
+++ llvm/include/llvm/ExecutionEngine/JITLink/aarch64.h
@@ -43,6 +43,8 @@
 /// only
 const char *getEdgeKindName(Edge::Kind K);
 
+bool isLoadStoreImm12(uint32_t Instr);
+
 unsigned getPageOffset12Shift(uint32_t Instr);
 
 Error applyFixup(LinkGraph &G, Block &B, const Edge &E);


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D126628.432864.patch
Type: text/x-patch
Size: 1384 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220530/59bdf269/attachment.bin>