[PATCH] D126591: [InstCombine] Optimise shift+and+boolean conversion pattern to simple comparison

Sun May 29 09:53:10 PDT 2022

bcl5980 added a comment.

In D126591#3544495 <https://reviews.llvm.org/D126591#3544495>, @spatel wrote:

> Codegen looks better in all cases that I checked, so that's good. And I'm assuming there are no existing regressions on tests.
>
> But this is really 3-4 independent patches together now. Please split it up for easier review and less risk.
>
> I'd start with the 'shift+and' transforms: please add tests where the intermediate values have extra uses and commit those with baseline results. Then post those as new reviews with the corresponding Alive2 proofs, so we have the correctness check for each transform.

I'm sorry but I have a question about the ninja check. What is difference between pre-merge checks and local ninja check test? I try to test local but a lot of test failures on bolt, clang, lld. There is no IR failure.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126591/new/

https://reviews.llvm.org/D126591