[PATCH] D126591: [InstCombine] Optimise shift+and+boolean conversion pattern to simple comparison

[Sanjay Patel via Phabricator via llvm-commits]

spatel added a comment.

Codegen looks better in all cases that I checked, so that's good. And I'm assuming there are no existing regressions on tests.

But this is really 3-4 independent patches together now. Please split it up for easier review and less risk.

I'd start with the 'shift+and' transforms: please add tests where the intermediate values have extra uses and commit those with baseline results. Then post those as new reviews with the corresponding Alive2 proofs, so we have the correctness check for each transform.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126591/new/

https://reviews.llvm.org/D126591