[PATCH] D126465: [RISCV] Use knowledge of VLEN to avoid over-aligning the stack

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 26 10:33:23 PDT 2022


craig.topper added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVFrameLowering.cpp:896
+  // alignment. We can take this into account to avoid over-aligning the stack.
+  // Since VLEN is always a power of two greater than 32, knowing the minimum
+  // VLEN is enough to ensure the same alignment with larger VLENs.
----------------
VLEN can be 32. But our calculation of vscale and scalable types is broken for it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126465/new/

https://reviews.llvm.org/D126465



More information about the llvm-commits mailing list