[PATCH] D126421: ADT/ArrayRef: Add makeMutableArrayRef overloads

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: llvm/unittests/ADT/MutableArrayRefTest.cpp:19
+// Test that makeArrayRef works on ArrayRef (no-op)
+TEST(MutableArrayRefTest, makeMutableArrayRef) {
+  int A;
----------------
You may reuse ArrayRefTest.cpp since we use ArrayRef.h instead of MutableArrayRef.h.

There should be a test checking that the element is mutable.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126421/new/

https://reviews.llvm.org/D126421