[PATCH] D126421: ADT/ArrayRef: Add makeMutableArrayRef overloads

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 25 13:49:28 PDT 2022


efriedma added inline comments.


================
Comment at: llvm/include/llvm/ADT/ArrayRef.h:549
+
+  template <typename T, unsigned N>
+  MutableArrayRef<T> makeMutableArrayRef(SmallVector<T, N> &Vec) {
----------------
Missing doc comment?


================
Comment at: llvm/unittests/ADT/MutableArrayRefTest.cpp:18
+
+// Test that makeArrayRef works on ArrayRef (no-op)
+TEST(MutableArrayRefTest, makeMutableArrayRef) {
----------------
This comment doesn't really make sense.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126421/new/

https://reviews.llvm.org/D126421



More information about the llvm-commits mailing list