[PATCH] D118269: [gn build] Make HAVE_MALLINFO2 a gn arg, default to false

Arthur Eubanks via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 25 13:35:28 PDT 2022


aeubanks added inline comments.


================
Comment at: llvm/utils/gn/secondary/llvm/include/llvm/Config/BUILD.gn:52
+  # TODO: remove this once nobody using the gn build is building against an old glibc.
+  llvm_have_mallinfo2 = false
 }
----------------
pcc wrote:
> Shouldn't the default be true? If the default assumption that we make in the gn build is that glibc is up to date, users of older glibc should be the ones who need to request the non-default behavior.
The question is which default inconveniences the fewest people. It probably makes sense to set this to true by default now: https://reviews.llvm.org/D126415


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118269/new/

https://reviews.llvm.org/D118269



More information about the llvm-commits mailing list