[PATCH] D118269: [gn build] Make HAVE_MALLINFO2 a gn arg, default to false

Peter Collingbourne via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 25 11:48:24 PDT 2022


pcc added inline comments.
Herald added a project: All.


================
Comment at: llvm/utils/gn/secondary/llvm/include/llvm/Config/BUILD.gn:52
+  # TODO: remove this once nobody using the gn build is building against an old glibc.
+  llvm_have_mallinfo2 = false
 }
----------------
Shouldn't the default be true? If the default assumption that we make in the gn build is that glibc is up to date, users of older glibc should be the ones who need to request the non-default behavior.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118269/new/

https://reviews.llvm.org/D118269



More information about the llvm-commits mailing list